Fix bug when reading linux defaults#2259
Merged
mjcheetham merged 1 commit intogit-ecosystem:mainfrom Feb 4, 2026
Merged
Conversation
If there is no GCM configuration defaults directory on Linux, we had been inadvertently returning `null` for the setting value! Fix the issue by explictly returning `false` (no setting found) to `TryGetExternalDefault` rather than `true` (setting found). Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
dscho
approved these changes
Feb 4, 2026
Merged
mjcheetham
added a commit
that referenced
this pull request
Feb 4, 2026
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is no GCM configuration defaults directory on Linux, we had been inadvertently returning
nullfor the setting value!Fix the issue by explictly returning
false(no setting found) toTryGetExternalDefaultrather thantrue(setting found).